FLUID-4205: UI Enhancer attaches itself to container - UI Options assumes "document'

Metadata

Source
FLUID-4205
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Michelle D'Souza
Reporter
Anastasia Cheetham
Created
2011-05-05T15:54:10.653-0400
Updated
2011-06-20T16:39:56.511-0400
Versions
  1. 1.3.1
Fixed Versions
  1. 1.4
Component
  1. UIEnhancer
  2. UI Options

Description

The UI Enhancer accepts an optional "container" argument as its first parameter. If not provided, the container defaults to "document." The UI Enhancer attaches itself to this container for UI Options to find later.

UI Options always expects the UI Enhancer to be attached to "document". If UI Enhancer is actually initialized with a container other than "document", then the initialization of UI Options fails because it doesn't find the Enhancer attached to "document."

I'm not sure what the right solution is:

A) For UI Enhancer to always attached itself to "document" only.
B) Have UI Options accept a configuration parameter letting it know where to find the enhancer.
C) Have UI Options search for the UI Enhancer somehow.

None of these are ideal. Other suggestions?

Comments

  • Anastasia Cheetham commented 2011-05-05T15:59:03.283-0400

    At Justin's request, I'm updating "Fix version" to 1.4 so that we don't forget to at least consider this issue before the release. It will probably take a bit of thinking and considering.

  • Justin Obara commented 2011-05-17T09:40:43.583-0400

    Bug Parade Infusion

  • Michelle D'Souza commented 2011-05-26T14:04:16.204-0400

    Should be fixed with pull request: https://github.com/fluid-project/infusion/pull/55