FLUID-4173: Add an "active" style for fl-list-menu

Metadata

Source
FLUID-4173
Type
Improvement
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
heidi valles
Reporter
heidi valles
Created
2011-04-04T10:24:37.604-0400
Updated
2011-04-19T14:45:08.633-0400
Versions
  1. 1.3.1
Fixed Versions
  1. 1.4
Component
  1. FSS

Description

It seems like the list-menu styles should include an "active" option.

Attachments

Comments

  • heidi valles commented 2011-04-11T12:03:37.384-0400

    webapp/demos/fss/layout/css/layout.css has fl-activemenu , seems like it just needs to be renamed/added to fss-layout

  • heidi valles commented 2011-04-12T09:35:46.263-0400

    Branch up at https://github.com/heidiv/infusion/tree/FLUID-4173 - Added activemenu and hover styles to fss-layout.css for fl-list-menu. Also edited the theme styles to apply activemenu correctly by styling the link, not the li. Was not being applied before. The colour choices for some of the themes activemenu (light grey text on a lighter grey background - hard to read) seem wrong, but will leave as is for now.

  • heidi valles commented 2011-04-12T09:37:15.373-0400

    Hey Justin, can you have a look at this and let me know what you think? Attached is a test page for a list I put in /demos/fss if that helps.

  • Justin Obara commented 2011-04-14T12:54:50.439-0400

    Heidi I've tried the fss themes demo in your branch. I'm noticing that there are some contrast issues for some of the themes. For example, with slate and coal it is hard to read the text of the active menu. For Mist the text changes to white when it is hovered over, which is the same colour as it's background.

  • heidi valles commented 2011-04-14T15:39:01.882-0400

    Colours updated/fixed and added to my github branch.

  • Justin Obara commented 2011-04-19T14:45:08.631-0400

    I've pushed the FLUID-4173 changes from heidi's branch into the project repo at fd9978f0dbe114c186eca0d95493e5861acc17ae, also had to fix a minor merge conflict