Metadata
- Source
- FLUID-4108
- Type
- Bug
- Priority
- Blocker
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Colin Clark
- Reporter
- Colin Clark
- Created
2011-02-23T14:36:13.938-0500 - Updated
2011-02-24T17:05:12.471-0500 - Versions
-
- 1.3
- Fixed Versions
-
- 1.3.1
- Component
-
- Framework
Description
ProgressiveEnhancement.js fails in IE7 due to the fact that it accesses window.XMLHttpRequest.prototype, which is not present in IE7 (surprise surprise).
Here's the bug report from the channel logs:
golam: Justin_o: All framework unit tests showing error when page loads on IE7
[12:47pm] Justin_o: harriswong: if everything works after that, could you please file a jira against the url rewriting in the build process
[12:48pm] Justin_o: golam: intersting... is it the same error as the inline edit ones?
[12:50pm] golam: Justin_o: line: 20617 char:9 Error: 'window.XMLHttpRequest.prototype.sendAsBinary' is null or not an object
Here's the offending code:
var canSendBinary = window.FormData || (window.XMLHttpRequest && window.XMLHttpRequest.prototype.sendAsBinary);
It should be straight forward to make a fix: check window.XMLHttpRequest.prototype before accessing properties on it.
Environments
Internet Explorer 7
Comments
-
Anastasia Cheetham commented
2011-02-23T16:07:07.136-0500 I've tested the fix Colin pushed to his git repository, and it seems to work fine: The error is no longer thrown and the uploader works.