FLUID-4036: Pager dependent on rsf:ids for sortable columns

Metadata

Source
FLUID-4036
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Anastasia Cheetham
Created
2011-01-20T11:27:27.291-0500
Updated
2014-05-13T15:33:15.765-0400
Versions
  1. 1.3
  2. 1.4
Fixed Versions
  1. 1.5
Component
  1. Pager

Description

The Pager currently requires rsf:ids on column headers and the column row in order to use sortable columns. We need to re-do this to use general selectors instead.

Attachments

Comments

  • Anastasia Cheetham commented 2011-01-20T11:29:18.076-0500

    I'm not sure whether or not we should fix this rsf:id issue right away, or wait until we completely re-write the Pager to use IoC (FLUID-4035).

  • Colin Clark commented 2011-01-25T12:54:36.851-0500

    We should fix the Pager as-is, and not depend on the task of converting Pager to IoC, which may not happen for a while.

  • Justin Obara commented 2011-01-26T11:27:38.752-0500

    FLUID-4036-v1.patch.txt is a first pass at allowing the pager to use cutpoints. I have added a simple unit test and updated the demo to use selectors instead of rsf:ids. Everything seems to be working, but the code to get it to work could definitely use some cleanup, if not an entirely different approach.

  • Justin Obara commented 2011-02-07T15:39:55.028-0500

    I've done some more work in a branch in my github account ( https://github.com/jobara/infusion/tree/FLUID-4036 ). I've started making use of rendererCompoents. Still a bunch of work to be done though.

  • Antranig Basman commented 2013-07-22T21:13:36.564-0400

    Merged into trunk at revision acf4633 - Page now uses standard (old-style) RendererComponents throughout

  • Anastasia Cheetham commented 2014-03-03T11:47:10.826-0500

    The Pager demo HTML still has rsf:id attributes throughout. Since these demos serve as examples of how to use the components, we should clean the HTML up to reflect recommended practice.

  • Michelle D'Souza commented 2014-04-04T15:25:02.391-0400

    For 2.0 we should remove all references to rsf:id in the entire codebase.

  • Justin Obara commented 2014-05-08T10:46:29.683-0400

    Submitted a pull request to remove the use of ref:id's from the pager demos and tests.
    https://github.com/fluid-project/infusion/pull/514

  • Anastasia Cheetham commented 2014-05-12T11:47:34.760-0400

    Merged at 60b0f8ba37d58f6767039da2ccda900a96fcc94e