FLUID-4029: Progress width calculation doesn't include container's padding

Metadata

Source
FLUID-4029
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
heidi valles
Reporter
heidi valles
Created
2011-01-13T14:05:11.744-0500
Updated
2011-02-14T10:50:16.693-0500
Versions
  1. 1.3
Fixed Versions
  1. 1.3.1
Component
  1. Progress

Description

line 77:
return Math.round((Math.min(percent, 100) * that.progressBar.width()) / 100);

should be
return Math.round((Math.min(percent, 100) * that.progressBar.innerWidth()) / 100);

So that any padding in the container that progress bar is filling is included in its width calculation.

Attachments

Comments

  • heidi valles commented 2011-01-13T14:15:01.539-0500

    units tests still pass

  • Colin Clark commented 2011-01-27T19:29:13.072-0500

    Hi Heidi,

    Thanks for the patch. On Firefox 3.6, it seems to cause the total file progress area to overflow, causing scroll bars. Can you take a look?

  • heidi valles commented 2011-02-02T13:38:42.504-0500

    The scroll bar issue is fixed by the updated Uploader.css in FLUID-3837. Progress tests and demo still good.

  • Michelle D'Souza commented 2011-02-12T13:21:36.256-0500

    Pushed to Infusion project repository at commit 6368e698fd1a8d22fcbb

    Heidi, please check that it's working as you expect.