FLUID-4022: Reconsider using important! tag

Metadata

Source
FLUID-4022
Type
Improvement
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
heidi valles
Reporter
heidi valles
Created
2011-01-07T10:19:43.269-0500
Updated
2011-06-07T14:00:44.695-0400
Versions
  1. 1.3
Fixed Versions
  1. 1.4
Component
  1. FSS

Description

The important! tag is a problem as it's not over-ride-able, forcing the user to edit fss itself. With uportal, it is often the case that stylesheets are added in layers (site->skin->portlet), making fss on the site level especially frustrating.

!important is used in:

fss-layout.css
fss-text.css
fss-theme-coal.css
fss-theme-hc.css
fss-theme-hci.css
fss-theme-mist.css
fss-theme-rust.css
fss-theme-slate.css

Comments

  • heidi valles commented 2011-03-07T16:40:35.503-0500

    How enhancer applies styles now:
    -remove clashing classes from container (<body>)
    -add styles for font, spacing, theme, layout on container
    -remove background images if chosen
    -sets text size on container
    -sets line spacing on container
    -sets table of contents
    -styles links
    -styles inputs

    All FSS stylesheets are added by user into the <head>, Enhancer adds/removes fl- classnames as appropriate to reflect user's options.

  • heidi valles commented 2011-04-15T12:12:22.564-0400

    Pull request sent for branch in my github. !importants removed except for where they make sense in fss-layout (linear and no bg imgs).

  • Justin Obara commented 2011-04-19T14:42:18.056-0400

    I've pushed the changes, from heidi's branch for this issue, into the project repo at fd9978f0dbe114c186eca0d95493e5861acc17ae

  • Anastasia Cheetham commented 2011-06-02T14:30:26.013-0400

    There are still four !important tags in the HCI theme that are unrelated to background images. Removing them doesn't seem make any of the FSS styles/widgets look any different, except for actually improving the widget by making the border visible. This might want to be addressed in conjunction with FLUID-4219.

  • heidi valles commented 2011-06-06T10:20:46.125-0400

    https://github.com/fluid-project/infusion/pull/65

  • Justin Obara commented 2011-06-07T14:00:30.646-0400

    setting resolution

  • Justin Obara commented 2011-06-07T14:00:44.694-0400

    Merged into the project repo at e2281c2845b279948bb579b7e0d07591ea6c3bc8