Metadata
- Source
- FLUID-4021
- Type
- Bug
- Priority
- Minor
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Justin Obara
- Reporter
- Anastasia Cheetham
- Created
2011-01-05T16:15:30.602-0500 - Updated
2014-03-03T11:48:02.132-0500 - Versions
-
- 1.3
- 1.4
- Fixed Versions
-
- 1.5
- Component
-
- Demos
- Pager
Description
The Pager demo code sets a "model" option in the options argument to the creator function, as so:
demo.pager = fluid.pager(".demo-pager-container", {
dataModel: model,
model: {
pageSize: 10
},
....
In fact, the default value for pageSize is 10, so this is completely unnecessary. Since the demo is meant to be an exemplar, this might be confusing to readers. We might want to change it to something other than the default.
Also:
The bodyRenderer options include an option to set the renderer debugMode to false.
bodyRenderer: {
type: "fluid.pager.selfRender",
options: {
selectors: {
root: ".demo-pager-table-data"
},
renderOptions: {debugMode: false}
}
}
I believe this is the default; if so, we could remove this.
Comments
-
Anastasia Cheetham commented
2011-01-05T16:22:24.353-0500 Jon, you did a fair bit of work on the Pager demo - do you know if there is a reason why this option is being set?
-
Antranig Basman commented
2013-07-22T21:19:21.365-0400 Demo options improved to alter the required page size to 20, different from the defaults. the debugMode flag is now commented in the demo code. Merged into trunk at revision acf4633