FLUID-4016: Investigate and possibly remove "stylisticOffset" from reorderer options

Metadata

Source
FLUID-4016
Type
Task
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
heidi valles
Created
2010-12-22T15:52:59.822-0500
Updated
2018-03-21T08:53:32.004-0400
Versions
  1. 1.3
Fixed Versions
  1. 3.0
Component
  1. Reorderer

Description

stylisticOffset is a selector in the Reorderer's defaults, but doesn't appear to be used in the code, or documented. Seems like it should be removed.

Comments

  • Antranig Basman commented 2010-12-22T15:59:34.923-0500

    We will remove this as soon as trunk unfreeze for 1.4. It might be worth a small historical search to discover when exactly this selector became disused and whether it was intended that whatever facility it offers can be achieved by some other means or was deemed undesirable for some other reason.

  • Justin Obara commented 2018-03-09T11:20:03.842-0500

    Related to the above investigation request. I've done a

    git log -S"stylisticOffset"

    on the repo. It produced the following revisions from most recent:

    • 8b9e81234b20659e8e03f166d0def9dd8881b7a8
    • 36fd690f483c7008c8eda35729ad7cb7cc07939e
    • 36fd690f483c7008c8eda35729ad7cb7cc07939e

    While in the bottom two show the current additions of the stylisticOffset. I didn't locate any where that it was actually being used, or any real indication for what it was for.

  • Justin Obara commented 2018-03-20T10:12:50.386-0400

    Merged PR ( https://github.com/fluid-project/infusion/pull/881 ) into the project repo at 9954bf9a214c5c8e2e405ca6c543283da40a0f97

  • Justin Obara commented 2018-03-21T08:53:27.357-0400

    Merged Infusion-Docs PR ( https://github.com/fluid-project/infusion-docs/pull/133 ) at d942655fb33122a9cfa36b605bd086a00e78ca32