FLUID-3965: Table of Contents preference has no effect

Description

The Table of Contents setting in UIOptions doesn't seem to be working. It has no effect on the preview, and if you save it "on", you don't actually get a table of contents.

To reproduce:
1) Visit the Sakai demo: http://build.fluidproject.org/infusion/integration-demos/sakai/html/ui-options-fss-sakai.html
2) Open the UI Options dialog, choose "Easier to Find" and switch the Table of Contents radio button to "Yes"
---> You should see a Table of Contents in the Preview window, but you don't
3) Save these preferences
---> You should get a Table of Contents on your page, but you don't

Environments

FF3.6 on Mac OS 10.6
FF3.6 on Win 7
FF4 on Mac OS 10.6
FF4 on WIn 7
Chrome8 on Win XP
FF3.6 on Win XP
IE6 on Win XP
IE7 on Win XP
IE8 on Win XP

Attachments

• FLUID-3965.patch.txt

Comments

• Anastasia Cheetham commented 2010-12-20T13:37:52.758-0500

  This might be related: While the "Table of Contents" option is set to "Yes", changes to the "Links" options have no visual effect on the Preview: choosing Larger or Underline does nothing. If you then turn the "Table of Contents" option back to "Off," your Links preferences will be reflected in the Preview. If the ToC is on and you try the link settings and can't see them in the preview, then they won't be saved.

• Jen Chow commented 2010-12-20T15:31:39.781-0500

  On the fluid project demo portal, clicking "yes" for table of contents option on IE6 and IE7 results in a bug prompt relating to fluid.fetchResources.

• James Yoon commented 2010-12-20T15:34:26.864-0500

  Table of contents not working in the standalone demos either

  (e.g., http://build.fluidproject.org/infusion/standalone-demos/table-of-contents/html/TableOfContents.html)

• Anastasia Cheetham commented 2010-12-21T10:03:44.444-0500

  These errors are all being caused because FluidRequests.js is not being linked in the headers of the HTML files. fluid.fetchResources() was moved into that file, and now these pages can't find that function. Adding the file to the UIOptions component html file, and to the standalone Table of Contents demo, is all that would be required to fix it.

  The dependencies in the JSON files are fine: the framework dependencies do include the FluidRequests.js file, and UIOptions does work with a custom-build concatenated MyInfusion.js

• Anastasia Cheetham commented 2010-12-21T10:27:57.986-0500

  Michelle, I've attached a patch which addresses all of the issues described by this JIRA.

• Michelle D'Souza commented 2010-12-21T10:49:37.316-0500

  The patch looks good. One thing that I noticed is that there is a UIEnhancer used in the uportal integration example and that example does not include the FluidRequests javascript file. This is fine for the current example because the UIEnhancer is hooked up to the links to select particular themes and it does not use the TableOfContents. This could become a problem if we ever decide to include a TableOfContents in this integration example but given that it is scheduled for removal once we get better examples in place this is very unlikely.

  This can now be committed and we should run a very basic QA in several browsers.

• Anastasia Cheetham commented 2010-12-21T11:40:08.774-0500

  This patch was committed at r10446. Looks good now.