FLUID-3952: In Firefox 3.6, the HTML 5 strategy for Uploader sends an invalid multipart request, causing uploads to fail in PHP

Metadata

Source
FLUID-3952
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Mike Lam
Reporter
Colin Clark
Created
2010-12-17T18:46:26.684-0500
Updated
2010-12-20T16:22:54.873-0500
Versions
N/A
Fixed Versions
  1. 1.3
Component
  1. Uploader

Description

On line 202 of HTML5UploaderSupport.js, in the generateMultipartContent() method, we hand roll our own multipart request to send via XHR. However, we mistakenly start the the message with a single whitespace character (" "), which is not a valid. This causes an the request to be ignored as malformed by PHP.

The fix is super easy: just remove the space at line 202, and suddenly PHP likes us again.

Attachments

Comments

  • Colin Clark commented 2010-12-17T18:52:11.235-0500

    I've committed a simple server debugging script written in PHP by Cindy, which is very helpful in debugging Upload issues with the server. It's located in the scratchpad: https://source.fluidproject.org/svn/scratchpad/uploader/simple-server-debug

  • Mike Lam commented 2010-12-20T10:12:58.314-0500

    Removed a space in the multi-part request so that the Uploader will upload files properly to PHP-based servers in FF 3.6

  • Michelle D'Souza commented 2010-12-20T15:46:08.083-0500

    Yep, the patch indeed removes the invalid leading space. Reviewed and ready to commit.

  • Colin Clark commented 2010-12-20T16:22:54.764-0500

    I committed MIke's patch at r10443 after Michelle reviewed it.