FLUID-3937: In Firefox 3.6, the HTML 5 strategy for Uploader loads files into memory instead of streaming to the server, causing the potential for browser crashes

Metadata

Source
FLUID-3937
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Colin Clark
Created
2010-12-17T11:49:19.057-0500
Updated
2010-12-20T16:24:18.342-0500
Versions
N/A
Fixed Versions
  1. 1.3
Component
  1. Uploader

Description

Firefox 3.6 only has partial support for HTML 5 multi file uploads. As a result, we are required to use the File API's .getAsBinary() method to load the entire file into browser memory before uploading it to the server.

This approach has the potential to cause crashes in browsers with large file sizes or in low memory situations. The bug itself is in Firefox's implementation, but we need to add some kind of sensible file size cap for users of Firefox 3.6 so that we don't end up crashing their browser.

Attachments

Comments

  • Colin Clark commented 2010-12-20T15:46:22.189-0500

    Here's a patch from Mike and I, which adds an additional "legacyBrowserFileLimit" option to the HTML 5 strategy so that users can cap file sizes selectively for Firefox 3.6.

  • Michelle D'Souza commented 2010-12-20T16:01:33.074-0500

    The patch looks good - you can commit.

  • Colin Clark commented 2010-12-20T16:23:37.994-0500

    Fix committed at r10444.

  • Colin Clark commented 2010-12-20T16:24:18.333-0500

    Fixed, tested and committed.