FLUID-3892: Move ProgressiveEnhancement into its own module

Description

The inclusion of ProgressiveEnhancement.js in the framework causes a dependency on swfobject that breaks with InfusionAll.js because of the order of inclusion of the files. After a discussion in the channel
http://wiki.fluidproject.org/display/fluid/fluid-work+IRC+Logs-2010-12-10
we decide to move ProgressiveEnhancement.js into its own module, fix it to check for the existence of swfobject before using it, and to make Uploader dependent on this module.

"Bug Parade Infusion 1.3"

Attachments

• FLUID-3892.patch.txt

Comments

• Justin Obara commented 2010-12-10T14:42:00.754-0500

  "Bug Parade Infusion 1.3"

• Anastasia Cheetham commented 2010-12-10T17:00:45.706-0500

  This patch (FLUID-3892.patch.txt) moves ProgressiveEnhancement.js into its own module, and adds a check for the existence of swfobject. I've tested various custom build configuration, and it seems to correctly include or not include the new module as appropriate. The Uploader demo and template still work, tests still pass.

• Anastasia Cheetham commented 2010-12-10T17:01:52.974-0500

  Colin, I've attached a patch for this. I've tested it on a machine that has Flash, but not one that doesn't, so that should probably be checked.

• Colin Clark commented 2010-12-11T13:26:58.924-0500

  Reopening in order to change resolution after committing a modified version of Anastasia's patch.

• Colin Clark commented 2010-12-11T13:29:33.642-0500

  I committed a modified version of Anastasia's patch to trunk at r10391. Changes to the patch included: 1) using "enhancement" as the module name for improved brevity, 2) creating a cleaner implementation of the flash check, 2) removing ProgressiveEnhancement.js from the framework dependency file. I've tested this in several ways, but Anastasia can you look over my changes, test, and close this issue if you're happy with the modified fix?

• Anastasia Cheetham commented 2010-12-13T10:24:38.004-0500

  Colin's commit works fine with all the test scenarios I've tried. His version of the Flash test is much better.