FLUID-3887: Rich Inline Edit creates a misleading hover style and tooltip

Metadata

Source
FLUID-3887
Type
Task
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Jonathan Hung
Created
2010-12-09T12:39:36.496-0500
Updated
2011-02-14T13:37:26.683-0500
Versions
  1. 1.3
Fixed Versions
  1. 1.3.1
Component
  1. Inline Edit

Description

The Rich Text Inline Edit component produces a highlight that implies that an entire container is clickable, while only the button is clickable.

However, the tooltip text is accurate for keyboard interaction since you can press enter when the highlight appears to enter Edit mode. (See Fluid-3911).

Also, the tooltip appears when hovering over this larger region and states that you can click anywhere to Edit - which is incorrect.

Comments

  • Jonathan Hung commented 2010-12-09T13:49:10.409-0500

    Patch to fix misleading tooltip text.

  • Jonathan Hung commented 2010-12-15T16:46:23.161-0500

    Tooltip text is appropriate for keyboard users, but not mouse users. This is because the interactions are different for both.

  • Colin Clark commented 2011-01-21T17:33:32.501-0500

    Heidi and Jess, can you work together on this issue once you've finished the higher-priority Uploader issues (including the FSS demo of the scrollable table classes)?

  • heidi valles commented 2011-01-26T17:06:16.457-0500

    Commented out rich text invitation style and edited the hover text. Basic fix. Working now on making it look like James's mockup from FLUID-3801 to see if it won't take too much more time.

  • heidi valles commented 2011-01-31T10:17:23.272-0500

    Hey Jon, could you check this one over and review the code before committing? Thanks!

  • Colin Clark commented 2011-02-09T16:39:50.141-0500

    Hi Heidi, Justin, Michelle and I took a look at your patch for this issue and have two suggestions:

    1. We should avoid commenting out code, and instead remove it entirely if it's no longer necessary.
    2. Can you have James or Jess review the invitation text to make sure it's awesome for users?

    Justin will commit the patch once you've had a chance to make those changes.

  • heidi valles commented 2011-02-10T13:05:48.397-0500

    branch with fixes up at https://github.com/heidiv/infusion/tree/FLUID-3887

  • Justin Obara commented 2011-02-11T15:41:56.711-0500

    Pushed Heidi's changes at 0eeadd6682a72c9cd4c0

  • Justin Obara commented 2011-02-11T15:42:00.165-0500

    Pushed Heidi's changes at 0eeadd6682a72c9cd4c0

  • Justin Obara commented 2011-02-14T13:36:19.875-0500

    just reopening to change the resolution to resolved