FLUID-3878: Improve Uploader's error messages, such as when selected files exceed fileQueueLimit

Description

Missing error messages for SWF and HTML5 uploaders when selected files exceed fileQueueLimit.

Symptom:

In the SWF uploader, if the selected files exceed the file queue limit, no error message is given to the user. Instead, nothing happens. No file is added to the queue. In the HTML5 uploader, files that don't exceed the file queue limit are added to the queue. Any additional files are left out. The SWF uploader never allows the fileQueueLimit to exceed fileUploadLimit, so a fileUploadLimit error should never happen.

Suggestion:

Render a message indicating what the file queue limit is, as well as, the file upload limit. We shouldn't be keeping these errors silent from the user.

Attachments

• FLUID-3878-alpha-patch.txt
• FLUID-3878-b-patch.txt
• FLUID-3878-c.patch.txt
• 
• 
• 
• 
• 
• 

Comments

• James Yoon commented 2011-01-13T14:56:23.182-0500

  Added wireframes for Uploader error handling, generally

  See wiki for more details on the design of Uploader error handling: http://wiki.fluidproject.org/display/fluid/Uploader+Wireframes+(Error+Handling)

• Harris Wong commented 2011-01-14T16:08:33.197-0500

  Things i have done:
  Uploader.js

  • added a listener for error events
  • added functions to print out and set error variables
  • added strings and constants for the ERROR flags

  HTML5UploaderSupport.js

  • fire an error when queue size is over the QUEUE_LIMIT

  FileQueue.js

  • added an object called "that.errorMsgs = {}" to keep track of all errors

  TODO:

  • print out individual file names categorized by the ERROR_CODE, which is stored in "that.errorMsgs"
  • clear the errorMsgs object when "Upload" is pressed
  • create a better HTML markup underneath the current component

• Harris Wong commented 2011-01-24T17:13:08.339-0500

  This alpha patch includes client error handling for both "Files too large", and "You have exceeded allowed file size" error.
  TODO:

  • clean up codes
  • clean up css
  • unit test

• Harris Wong commented 2011-01-29T17:12:30.648-0500

  TODO: Refractor test cases

• Harris Wong commented 2011-02-01T11:47:13.301-0500

  ErrorHandler component and its unit test for html5

• heidi valles commented 2011-02-02T14:39:15.989-0500

  The most recent patch makes changes to Uploader.html and Uploader.css, both of which are changed quite a bit in the patch for the Uploader's markup clean up. I wonder if we should wait until 3837 is committed as the error styles might need tweaking after that anyways. Thoughts?

• Harris Wong commented 2011-02-03T10:07:08.286-0500

  I think #3837 has more changes relative to this patch and it makes more sense to tweak this after #3837 is committed. If we commit this patch now, then it would probably cause a bigger conflict on #3837; whereas if we commit this after #3837, then the conflict should lie within this little component and is relatively easier to fix.

• heidi valles commented 2011-02-14T15:17:05.553-0500

  A few thoughts:
  -feel like 'add more' action should erase previous errors from 'browse files'
  -be nice to know the max # files allowed
  -would prefer 'x' to be top right. under warning icon it feels icon-y and not button-y. also right is where the 'x' is for file queue, used to it.
  -"which ones?": would prefer show/hide list
  -"heads up!": would prefer "notices", "warnings", or "errors"

• James Yoon commented 2011-02-14T15:32:21.680-0500

  Reply to Heidi's comments:

  • I agree, the "Add more" action should clear out all existing errors (additionally, the "Add more" action should be disabled when we reach the file queue limit)
  • New mockups show max # files allowed (a similar status should be considered for maximum file size)--this shouldn't be visible if the uploader allows unlimited files in the queue
  • New mockups show "x" for errors to the right of the error
  • New mockups show adjusted language ("show/hide" instead of "which ones", and "warnings" instead of "heads up")

• Harris Wong commented 2011-02-15T16:45:34.598-0500

  Applied Heidi's and James' suggestion to the uploader. Changes including the following:

  • New mockups show "x" for errors to the right of the error
  • New mockups images for 'x'
  • New mockups show adjusted language ("show/hide" instead of "which ones", and "warnings" instead of "heads up")
  • Click "Add more" will remove existing error.
  • Error Title now includes the number of files that failed to upload.
  • "Add more" button is disabled when the queue is fulled, enabled when it's not fulled.

• Justin Obara commented 2011-06-22T16:59:57.645-0400

  Bug Parade Infusion

• Michelle D'Souza commented 2011-06-24T12:39:11.180-0400

  Pull request https://github.com/fluid-project/infusion/pull/80/ merged into the project repo at 25fdd0dd5d44c2971785e8b64bb06231ae8eaa89