Metadata
- Source
- FLUID-3875
- Type
- Improvement
- Priority
- Critical
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Colin Clark
- Reporter
- Colin Clark
- Created
2010-12-02T18:51:42.378-0500 - Updated
2011-01-21T09:23:23.824-0500 - Versions
-
- 1.3
- Fixed Versions
- N/A
- Component
-
- Uploader
Description
In the new HTML 5 strategy for the Uploader, we have to hand-roll a standard multipart request in Firefox 3.6, due to the absence of the FormData object. Our current implementation works, but needs improvement, including:
- we hard code the multipart boundary, instead of randomly generating as is typical
- we need to verify that we correctly support the full UTF-8 character set, such as file names with special characters in them
- File.getAsBinary() is blocking, and may need to be replaced with Firefox's FileReader API
- concatenating strings and binary data together is sketchy, and we should verify that it's actually viable for any kind of file
Comments
-
Justin Obara commented
2010-12-03T08:50:49.576-0500 "Bug Parade Infusion 1.3"
-
Colin Clark commented
2010-12-12T23:08:19.264-0500 Mike has addressed the first issue mentioned here, along with unit tests for the whole implementation. While there's certainly more work that needs to be done here, I think we can go ahead and ship for Infusion 1.3.
-
Colin Clark commented
2010-12-12T23:09:03.477-0500 Changing the priority of this issue for the Infusion 1.3 release based on the fact that we have addressed the most substantial issues. The issue will stay open to be resolved fully for Infusion 1.4
-
Colin Clark commented
2011-01-21T09:23:16.644-0500 The core issues here have been resolved, and I've split out the remaining tasks into separate JIRAs, FLUID-4040 and FLUID-4041.