FLUID-3855: Simple Inline Edit Demo - Invitation text should be more informative and in a different colour and style.

Description

In the Simple Inline Edit Demo, the default invitation text (the text that appears when the editable text field is empty), should be in a different style and colour. As well, the text itself should be useful to the user giving them an indication of what to do.

Suggested style: italics with a grey colour.
Suggested invitation text: "Edit me", "Edit this", "Edit this text"

Currently the invitation text is indistinguishable from editable text.

Attachments

• FLUID-3855-1.patch
• FLUID-3855-2.patch
• FlUID-3855-3.patch

Comments

• Justin Obara commented 2010-11-19T16:19:06.800-0500

  "Bug Parade Infusion 1.3"

• Jonathan Hung commented 2010-11-26T14:03:28.967-0500

  Some of the changes shown in the demo patch should become new defaults for the component:
  1. component's defaultViewStyle style should be changed to match that of .demo-inlineEdit-invitation in the patch.
  2. component's defaultViewText variable in the JS file should change to "Edit this".

  Also:
  3. the Demo's Javascript is overloading classnames in some places (class used for both selecting and styling)
  4. some classes need better naming to follow convention.
  5. some instances where custom selector or style is defined where the component's default should be enough.

• Mike Lam commented 2010-11-26T15:11:20.210-0500

  Moved the defaultViewStyle from the demo to the component. Some CSS tweaks may be needed as the demo-inlineEdit-title style is overriding the italic styling of the defaultViewStyle.

• Mike Lam commented 2010-11-26T16:00:45.810-0500

  Set the demo font-size to 2em and removed 'normal'

• Michelle D'Souza commented 2010-12-01T17:04:58.341-0500

  I code reviewed this and am happy with it.