Metadata
- Source
- FLUID-3761
- Type
- Task
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Justin Obara
- Reporter
- Michelle D'Souza
- Created
2010-09-28T16:21:15.761-0400 - Updated
2011-07-08T16:23:08.740-0400 - Versions
- N/A
- Fixed Versions
-
- 1.4
- Component
-
- UI Options
Description
We want to have two preview options for UI Options. The current one, which is a preview pane that will be updated upon setting changes and another option which changes the entire page when a setting is changed. In order to do this, the preview needs to be made into a subcomponent of the ui options component.
Attachments
Comments
-
Michelle D'Souza commented
2010-09-28T16:27:09.268-0400 FLUID-3761-a.txt is a first pass at making the preview a subcomponent and using IoC to initialize it. A couple things need to be fixed for this to work as it did before the change.
1. the listener to the uiOptions component's modelChanged needs to be correctly attached
2. the preview enhancer's savedSettings and table of contents options needs to be correctly initialized -
Colin Clark commented
2010-09-29T12:43:59.028-0400 It sounds like we'll implement this as a series of preview strategies. The two obvious ones to start will be the "inline sample preview" (the one we currently have) and the "whole page" preview like we want to do for the IDI site.
-
heidi valles commented
2010-10-04T13:44:58.806-0400 patch A commited 10117.
still need to
-have frame preview contents load without hard refresh
-on preview load, use existing page settings
-create page preview subcomponent -
heidi valles commented
2011-01-25T15:48:11.652-0500 The attached incubator patch is a dump of the work Michelle and I did on this (but didn't finish) in the incubator. It's a diff between the time of the UIO incubator dir's creation (r10116) and the current trunk. We can apply the patch again once we come back to this, starting again where we left off. The work includes creating a preview subcomponent with IOC and modified tests to use it.
-
Justin Obara commented
2011-05-17T12:43:06.705-0400 Bug Parade Infusion
-
Justin Obara commented
2011-05-18T13:58:25.725-0400 Work for this issue was started under the FLUID-3782 branch ( https://github.com/heidiv/infusion/tree/FLUID-3782 ). New work should branch off from there and be continued under a branch specific to this jira.
-
Justin Obara commented
2011-05-18T14:14:57.661-0400 This is currently working with the latest changes that went into the FLUID-3782 branch. The fluid.uiOptions.preview and fluid.uiOptions.livePreview components are quite similar though. Once the issues with uiEnhancer are sorted out ( FLUID-4235 ), we might be able to refactor them into a single component.
-
Michelle D'Souza commented
2011-06-21T10:11:34.191-0400 The fixes in the FLUID-3782 branch were merged into the project repo with the FLUID-4267 branch at aa5efc1e1a20aaa152f2e7e2d4edfbb35e08c5ea
-
heidi valles commented
2011-07-06T14:15:18.882-0400 Merged in the live preview work justin/mike did and noticed a couple things:
-scrollbar on side shouldn't be there
-styles for drop down options missing (font and theme) -
Michelle D'Souza commented
2011-07-07T15:42:31.146-0400 Pull request https://github.com/fluid-project/infusion/pull/93 merged into project repo at f2422a49c04f6c4dcf25ab6132f176be9f5d522d
-
Michelle D'Souza commented
2011-07-07T15:52:53.986-0400 I opened 4331 for the scrollbar issue