Metadata
- Source
- FLUID-3757
- Type
- Task
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Justin Obara
- Reporter
- Antranig Basman
- Created
2010-09-26T04:47:57.986-0400 - Updated
2011-01-17T09:55:39.911-0500 - Versions
- N/A
- Fixed Versions
-
- 1.3
- Component
-
- Release
Description
Clean up comments, ensure public APIs are fully commented and JSLint new javascript files.
Note that this issue should only be in force before Code Freeze. Commits that alter actual code should not be permitted during Code Freeze.
Attachments
- FLUID-3757-delint-Escalated-tests-js.patch
- FLUID-3757-delint-frameworkTests.patch.txt
- FLUID-3757-delint-renderer.patch.txt
- FLUID-3757-jslint_componenttest.patch.txt
- FLUID-3757-jslint_standalondemos.patch.txt
- FLUID-3757-lintingFramework-DOMUtil-Doc-Debug.patch.txt
- jslint_manualtests.patch
- jslint_testcore.patch
Comments
-
Justin Obara commented
2010-10-04T14:00:46.598-0400 "Bug Parade Infusion 1.3"
-
Mike Lam commented
2010-12-14T17:52:22.517-0500 JS linted bottom 3 framework files
-
Anastasia Cheetham commented
2010-12-14T18:01:38.139-0500 This file (FLUID-3757-lintingFramework-DOMUtil-Doc-Debug.patch.txt) delints the following framework files: FluidDOMUtilities.js, FluidDocument.js, FluidDebugging.js
-
Anastasia Cheetham commented
2010-12-14T18:11:22.391-0500 This file (FLUID-3757-jslint_standalondemos.patch.txt) is Heidi's de-linting of the stand-alone demos.
-
Anastasia Cheetham commented
2010-12-14T18:16:11.652-0500 This file (FLUID-3757-jslint_componenttest.patch.txt) is Heidi's patch for the component test files. I'm not sure if it covers all of the tests - Heidi had to leave.
-
heidi valles commented
2010-12-15T10:41:21.247-0500 linting for /tests/manual-tests attached
-
heidi valles commented
2010-12-15T10:42:08.613-0500 Yes, component test patch is for entire dir
-
Anastasia Cheetham commented
2010-12-15T10:48:32.147-0500 This file (FLUID-3757-delint-frameworkTests.patch.txt) contains the de-linting of all JS files in the framework-tests folder. Not all files required changes.
-
Anastasia Cheetham commented
2010-12-15T11:50:48.689-0500 I've reviewed and committed Heidi's delinting of the component tests.
-
heidi valles commented
2010-12-15T12:05:38.260-0500 delinting of /tests/test-core patch
-
Anastasia Cheetham commented
2010-12-15T12:27:01.616-0500 I've reviewed and committed Heidi's patch that de-lints the test-core folder.
-
Anastasia Cheetham commented
2010-12-15T12:36:19.385-0500 I've reviewed and committed Heidi's de-linting of the standalone demos.
-
Anastasia Cheetham commented
2010-12-15T16:21:03.654-0500 Mike has linted some of the other framework files - he'll attach the patch after 1.3 QA
-
Justin Obara commented
2011-01-17T09:55:20.117-0500 Linting performed except for the framework code, which will be done for 1.3.1.