FLUID-3732: fluid.initSubcomponent() doesn't properly array-ify args if args is a jQuery object

Metadata

Source
FLUID-3732
Type
Bug
Priority
Major
Status
Closed
Resolution
Incomplete
Assignee
Antranig Basman
Reporter
Anastasia Cheetham
Created
2010-09-10T16:33:50.986-0400
Updated
2019-07-12T09:13:33.675-0400
Versions
  1. 1.1
  2. 1.2
  3. 1.3
  4. 1.4
Fixed Versions
  1. 2.0
Component
  1. Framework

Description

fluid.initSubcomponent() calls jQuery.makeArray() on the args parameter, just in case it's not actually an array.

If the args parameter happens to be a single jQuery object, however, all the call to jQuery.makeArray() does is strip off the non-arrayness of the object resulting in a pure Array of DOM nodes.

Comments

  • Anastasia Cheetham commented 2010-09-10T16:35:38.760-0400

    The only place I've noticed this so far is InlineEdit: that's the only code I've found that actually doesn't pass an array to initSubcomponents(). The only reason this doesn't cause a problem is because the subcomponents in question happen to work fine if passed a DOM node instead of the intended jQuery object. However, if the IoC system is used to create the subcomponents, mayhem ensues.

  • Justin Obara commented 2014-07-14T10:31:56.685-0400

    @@Antranig Basman can you verify if this is still an issue?

  • Antranig Basman commented 2015-08-20T21:45:36.300-0400

    initSubcomponent is no longer a supported API following this release, so the issue is null