FLUID-3672: event firer does not remove listeners of type 'function'

Metadata

Source
FLUID-3672
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Laurel Williams
Reporter
Laurel Williams
Created
2010-06-14T14:12:42.367-0400
Updated
2013-04-11T17:43:18.516-0400
Versions
  1. 1.2
Fixed Versions
  1. 1.3
Component
  1. Framework

Description

The fluid event firer object does not remove listeners of type function.

Environments

all

Attachments

Comments

  • Laurel Williams commented 2010-06-14T14:17:49.826-0400

    FLUID-3672-1.patch.txt includes a test to show the problem. Essentially, if you create an event firer, add a listener of type function, remove the listener and then fire the event, the listener has not been removed and runs.

    This patch also includes the fix for the problem, which includes a test for listeners of type 'function'.

  • Laurel Williams commented 2010-06-17T11:11:40.364-0400

    Attached patch (#2) is a second version of a fix for this problem, very similar to the first patch. The if statement in this case has been pared down to a minimal if statement with a test for the $$guid.

  • Anastasia Cheetham commented 2010-06-17T11:53:16.561-0400

    I've committed Laurel's patch for this.