FLUID-3483: Inline Edits internal call to updateModelValue does not include the source.

Metadata

Source
FLUID-3483
Type
Bug
Priority
Critical
Status
Closed
Resolution
Won't Fix
Assignee
Antranig Basman
Reporter
Justin Obara
Created
2010-01-22T09:12:04.000-0500
Updated
2014-06-25T16:16:10.995-0400
Versions
  1. 1.2
  2. 1.3
  3. 1.4
Fixed Versions
N/A
Component
  1. Inline Edit

Description

Inline Edits internal call to updateModelValue does not include the source

This results in the modelChanged event firing without source being undefined.

In contrast, the undo/redo facility does provide a source with the modelChange event.

This means that an integrator may not be able to listen to a single even for a model change if they also need to know the source (for example in the case where there are multiple inline edit fields on the page).

Comments

  • Antranig Basman commented 2014-04-02T15:22:12.293-0400

    This wasn't really the purpose of the "source" field which is a remnant of the "source tracking" operated by the old ChangeApplier. In practice, any new code listening to model changes can easily get access to the component reference through listener boiling so this isn't a practical problem any more.