FLUID-3378: Component Decorator contract is inconsistent

Metadata

Source
FLUID-3378
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Won't Fix
Assignee
N/A
Reporter
Anastasia Cheetham
Created
2009-11-10T16:46:00.000-0500
Updated
2010-03-30T13:27:05.000-0400
Versions
  1. 1.1.2
Fixed Versions
  1. 1.2
Component
  1. Framework
  2. Inline Edit
  3. Uploader

Description

Support for component decorators is implemented inconsistently. Currently, two components support decorators: Inline Edit and Uploader. The two components use a different option name to specify decorators: Inline Edit uses "componentDecorators" and Uploader uses "decorators."

Ideally, option names are consistent across all components, so we should decide on a name to standardize on, ensure that both of these components use the name, and properly document the name (it is not mentioned on the wiki page: http://wiki.fluidproject.org/display/fluid/Decorators)

Comments

  • Colin Clark commented 2010-03-30T13:25:14.000-0400

    This issue will be moot when we move to the new IoC system, as decorators will be assignable without the component specifically having to enable support for it. I don't think we can change the API of either Inline Edit or the Uploader at this point, so we'll have to live with the inconsistency.

    Future components, if they add support for decorators before we have the IoC system, should use the option name "decorators."

  • Colin Clark commented 2010-03-30T13:27:05.000-0400

    Can't fix this issue in Inline Edit without breaking API compatibility, and we won't need to sweat this at all when the new IoC system is in place.