Metadata
- Source
- FLUID-3349
- Type
- Bug
- Priority
- Blocker
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Laurel Williams
- Reporter
- Laurel Williams
- Created
2009-11-03T14:16:25.000-0500 - Updated
2009-12-02T13:36:31.000-0500 - Versions
- N/A
- Fixed Versions
-
- 1.2
- Component
-
- Infusion Builder
Description
At the moment, all of the logic inside builder.js is either legacy, unnecessary, or more correctly placed in the component itself. Let's do a bit of refactoring and get rid of builder.js entirely.
Attachments
Comments
-
Laurel Williams commented
2009-11-05T16:27:33.000-0500 The attached patch represents a partial solution to removing the code from builder.js. Tests are now failing, and the next step is to determine how to load the CustomBuild template into the tests via ajax, so that they are using the same template as the main code.
-
Colin Clark commented
2009-11-05T22:29:57.000-0500 Here's a modified version of Laurel's patch that gets about half of the unit tests passing. Other failures likely have to do with one of two things:
1. Hard-baked assumptions in tests about selector names that may have changed between the old test markup and the real template
2. The fact that the unit tests clean up the DOM after each test run, causing the component to be in an inconsistent state. -
Laurel Williams commented
2009-11-06T16:19:48.000-0500 Made a small change to the setup of the tests to recreate the component between each test. This solved the problem.