FLUID-3301: Selecting 'serif' from menu doesn't set font to serif

Description

When bringing up the UI Options dialog for the first time, the Serif font, being the first font in the list, is "selected" (even though the user hasn't set a preference for serif).

If you pull the menu down and click on Serif, this still doesn't "set" the preference to Serif (presumably because the value of the control hasn't changed) and so the preview doesn't change, and if you save the settings, the site doesn't change.

If you select a different font, and then select serif, it works fine.

Environments

FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
Safari 3.2 (Mac OS 10.4)
FF2, FF3, IE6, IE7, IE8, Opera 9.6 (Win XP)
FF3, IE7, IE8 (Win Vista)
IE6 (Win 2000)

Comments

• Cindy Li commented 2011-04-21T09:34:21.835-0400

  Fixed at git commit: 2c758f61c1a2355ba8a5

  Set "arial" as initial default value of font style, instead of "serif".

• Cindy Li commented 2011-05-06T14:00:32.452-0400

  This issue needs more considerations. Setting default to "Arial" fixes the issue because our demo pages happen to use "Arial" font. This fix seems likely introducing another bug that the user's pages are forced to be initialized with "Arial" font. The previous default, a empty string, makes more sense in this case. However, with an empty default font, the users have to supply whatever font they use into UIEnhancer defaults block, which may not be a ideal as well.

• Anastasia Cheetham commented 2011-05-06T15:03:40.063-0400

  I believe the new designs for UI Options include a "keep the page's original settings" option in the various pull-downs: Something that can be selected to indicated that the Enhancer shouldn't do anything that affects the font family. This should be the default setting when UI Options is first opened. The implementer wouldn't have to inform the Enhancer of what the default font is, since the default is "whatever the page originally specifies."

• Justin Obara commented 2011-05-17T12:42:44.910-0400

  Bug Parade Infusion

• Cindy Li commented 2011-05-24T11:19:29.584-0400

  This issue is resolved with the new UI Options wireframe design. As Anastania mentioned, a "default" font value is introduced and it is the default selection on the font drop down list box. This value means leaving whatever on the user's page, which fits the current behaviour.