FLUID-3277: Attempt to add children to leaf component in tree results in "targetlump is undefined" error

Metadata

Source
FLUID-3277
Type
Bug
Priority
Critical
Status
Closed
Resolution
Won't Fix
Assignee
Antranig Basman
Reporter
Antranig Basman
Created
2009-10-09T14:02:08.000-0400
Updated
2014-04-02T15:16:59.612-0400
Versions
  1. 1.1.2
  2. 1.2
Fixed Versions
N/A
Component
  1. Renderer

Description

Below is a section of component tree - in it, "title-plain" is a leaf node, but is presented with children, because its markup contains further nodes. This triggers the "erroneous branch", currently at line 1778 of the renderer:

if (component && component.children !== undefined) {
renderContainer(component);
renderindex = lump.close_tag.lumpindex + 1;
}

which can never execute correctly since it does not supply a target branch point. Behaviour in this case should be clarified and a reasonable diagnostic issued.

var fullTree = {
children: [
// The colon (🙂 at the end of the rsf ID identifies the component as a repeating
// component. In this full tree, there is one object for each repeated component.
{
ID: "resource-item:",
children: [ {
ID: "title-plain",
decorators: [
{
type: "addClass",
classes: "level0"
}
],
children: [ {
ID: "title-link",
linktext: "My Workspace",
target: "/user/jimeng/",
decorators: [{
attrs: {title: "Folder"}
}]

}, {
ID: "title-image",
target: "../images/dir_closed.gif",
decorators: [{
attrs: {alt: "Folder"}
}]
}]

} ]
},

Comments

  • Anastasia Cheetham commented 2014-04-02T15:16:59.611-0400

    We will be rewriting the renderer instead of fixing this.