FLUID-326: Move Lightbox-specific code out of Fluid.js and into Lightbox.js

Metadata

Source
FLUID-326
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Michelle D'Souza
Reporter
Colin Clark
Created
2008-03-10T13:40:17.000-0400
Updated
2008-08-09T14:27:57.000-0400
Versions
  1. 0.1
Fixed Versions
  1. 0.3
Component
  1. Image Reorderer

Description

Lightbox-specific code such as initLightbox() should be moved into Lightbox.js. We should reserve Fluid.js for reusable functionality required by most Fluid components.

Attachments

Comments

  • Colin Clark commented 2008-03-10T13:43:30.000-0400

    Here's a patch that moves Lightbox-specific code out of Fluid.js and into Lightbox.js. It's also a significant refactoring, splitting up initLightbox() into three separate methods to make it more maintainable and reusable.

  • Colin Clark commented 2008-03-10T13:44:17.000-0400

    Michelle, can you review this patch and apply it if you think it's good, or offer comments if not?

  • Michelle D'Souza commented 2008-03-11T13:18:21.000-0400

    This patch looks good. I needed to make a few tiny tweaks to it such as modifying the generic lightbox template's init script. I will also need to commit a patch to the gallery as well because of the new namespace. (fluid.lightbox rather than fluid)