FLUID-3197: Add keyboard navigation and ARIA roles to the demo portal, particularly the code tabs.

Description

At the moment, we have a set of tabs for the code view for each component in the demo portal. These tabs have click handlers but no keyboard navigation or ARIA roles/states. We should add these, along with accessibility support to any other parts of the portal.

Attachments

• fluid-jira.patch
• fluid-jira.patch

Comments

• Justin Obara commented 2009-09-22T10:47:16.000-0400

  Bug Parade Infusion 1.1.2

• joan garcia commented 2009-09-29T07:21:18.000-0400

  Attached a patch to address this jira.

  Michelle could you validate that tabs work properly using the keyboard navigation?.
  Many thanks in advance.

  Tested on:
  SO: Ubuntu 9.04
  Linux pr040 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 2009 i686 GNU/Linux
  Browsers: Firefox 3.0.14 / 3.5.3

  • Main changes on:
    fluid-all/infusion/src/webapp/demos/portal/js/demoAssets.js

  cheers,

  joan.

• Jacob Farber commented 2009-09-29T14:13:14.000-0400

  I review the patch, it looks good.
  Thanks Joan,
  Jacob

• joan garcia commented 2009-10-01T05:11:33.000-0400

  Second patch for the issue.

  Applied Colin suggestion to code.

  Please colin and/or jacob, could you validate this new patch (overrides previous one)

• Colin Clark commented 2009-10-04T10:42:37.000-0400

  I've reviewed Joan's second patch and it looks great. I've applied it.

  In reviewing, I noticed we're still missing one thing: the anchors within the tabs should be taken out of the tab order with a tabindex of -1. I'll go ahead and implement this.

• Colin Clark commented 2009-10-04T10:42:59.000-0400

  Still need to remove the tab anchors from the tab order.

• Colin Clark commented 2009-10-04T10:52:43.000-0400

  I've removed the anchors from the tab order. Jacob can you take a quick peek just to be sure you approve?

• Jacob Farber commented 2009-10-05T10:49:24.000-0400

  There is a small bug - when the user tabs off of the Tabs, the selected Tab is no longer hilighted, and the colorized/plaintext links no longer work.

  Im going to make a small addition to ensure the active tab stays selected, and then post this for review.

• Colin Clark commented 2009-10-05T18:08:24.000-0400

  I've reviewed Jacob's last fix to this issue and it looks good. Also simplifies things a fair bit to remove the unnecessary call to activatable. Tests out in FF3.5.