FLUID-3182: The InlineEdit demo in the new demo portal has crufty code at the top of it.

Metadata

Source
FLUID-3182
Type
Sub-issue
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Jacob Farber
Reporter
Colin Clark
Created
2009-09-15T17:37:32.000-0400
Updated
2011-01-14T11:54:51.316-0500
Versions
N/A
Fixed Versions
  1. 1.1.2
Component
  1. Inline Edit

Description

The Inline Edit component demo has this code at the top of it:

/**

  • Customize the undo subcomponent appearance.
  • @param {Object} that
  • @param {Object} targetContainer
    */
    var myUndoRenderer = function (that, targetContainer) {
    var markup = "<span class='flc-undo'>" +
    "<span class='flc-undo-undoContainer'><a href='#' class='flc-undo-undoControl'><img src='../../../../integration-demos/sakai/images/undo.png' alt='Undo your edit' title='Undo your edit' style='border:none' /></a></span>" +
    "<span class='flc-undo-redoContainer'><a href='#' class='flc-undo-redoControl'><img src='../../../../integration-demos/sakai/images/redo.png' alt='Redo your edit' title='Redo your edit' style='border:none' /></a></span>" +
    "</span>";
    var markupNode = $(markup);
    targetContainer.append(markupNode);
    return markupNode;
    };

This is Eli's fancy undo/redo markup, but this renderer isn't hooked up anywhere. If we want to use it, we should hook it up, otherwise delete it.

Comments

  • Justin Obara commented 2009-09-22T10:55:45.000-0400

    Bug Parade Infusion 1.1.2

  • Jacob Farber commented 2009-09-22T23:09:04.000-0400

    Since we could implement a the function in the integration demo, I figured I could save you the trouble and just delete it from the simple demo.

  • Jacob Farber commented 2009-09-30T16:46:08.000-0400

    I removed the function, awaiting review

  • Colin Clark commented 2009-10-02T18:39:48.000-0400

    I've review Jacob's change and it looks good. +1

  • Michelle D'Souza commented 2011-01-14T11:27:03.034-0500

    Reopening these issues in order to add the inline edit component to them.