FLUID-3171: jquery sliders don't announce correct units in screen readers

Description

Give minimum text size jquery slider the correct units. should read "point" not "percent"

Attachments

• FLUID-3171.txt
• FLUID-3171b.txt
• FLUID-3171c.txt

Comments

• Justin Obara commented 2009-11-24T14:05:23.000-0500

  Code Review Comments:
  ===================

  This seems to work in NVDA in Firefox. Not working in JAWS.
  Was it working in all cases for you, or is this the case where JAWS and IE are lacking support.

  Line 132 - 133 could probably be put into one call using the object version of the attr function. Which you used in the undo patch.

  For the value of "aria-valuetext" you may want to look into our string templating scheme. Although it might be overkill in this case, you probably could at least move the unitText into a strings object, for consistency with other components.

  strings: {
  unitText: "point"
  }

  http://wiki.fluidproject.org/display/fluid/Framework+Functions#FrameworkFunctions-fluid.stringTemplate

  I think your test may actually be wrong.
  Line 49: I think slider.slider("value") should actually be "expected".

  You should be able to write " " + "point" as " point". You may also want to make a function to assemble this string and then have tests for different types of unitText options.

• Justin Obara commented 2010-01-05T17:02:57.000-0500

  Code Review Comments for the patch FLUID-3171c.txt
  ==========================================

  uiOptions.js
  ----------------
  line 158: by convention the unitTextTemplate should be in a strings object

  strings: {
  unitTextTemplate: "%val point"
  }

  TextFieldSliderTests.js
  ------------------------------
  the functions testValueTextSetting and testSetting look virtually identical.

  They seem to differ only on the format of the expected value for the valuetext test

  One way to handle this would be to pass in the concatenated string for the expected valuetext as a third variable.

• Justin Obara commented 2010-05-07T13:51:30.926-0400

  a11y issue

• Justin Obara commented 2014-07-14T07:02:47.464-0400

  Currently it seems that the textfield slider only reads the value and no units.

• Justin Obara commented 2024-07-22T12:25:19.606-0400

  Using a standard range input instead of jQuery slider now.