FLUID-3054: tiny_mce Inline Edit text editor fails when used with advanced theme

Description

When using tiny mce editor for inline text edit component with "advanced" theme tiny_mce editor opens and closes first time the user tries to edit text. This happens because tiny mce. To reprodcude:
1. create a tiny_mce example
2. pass {tinyMCE: {theme : "advanced"}} as the option when calling fluid.inlineEdit.tinyMCE()
3. run the demo and notice that component closes instantly after the first time it is being opened.

Attachments

• FLUID-3054_final.txt
• FLUID-3054.txt
• FLUID-3054-c.patch
• patch.txt

Comments

• y z commented 2009-07-22T16:23:04.000-0400

  Patch for review fixing the advance theme problem

• y z commented 2009-07-23T12:23:09.000-0400

  Polished patch for the issue

• Colin Clark commented 2009-07-23T16:07:18.000-0400

  I've attached a new patch that should resolve the issue. It does need some fairly substantial testing, since I changed the way options get merged before instantiating the actual InlineEdit instance.

• y z commented 2009-07-24T11:28:16.000-0400

  latest patch

• Justin Obara commented 2009-07-24T17:08:41.000-0400

  Committed Yura's latest patch, which solves the issue of the advanced themed tinyMCE from opening and closing when trying to launch it hte first time. This patch also removes the jquery.tinyMCE plugin. The one addition that I have made was to convert one of the tinyMCE examples in the inlineEdit quickstart example to use the advanced theme.

• Justin Obara commented 2009-07-27T17:19:53.000-0400

  Bug Parade 1.1.1 release

• Justin Obara commented 2009-07-28T07:33:26.000-0400

  This has now been back ported into the 1.1.x branch

• Antranig Basman commented 2009-07-30T12:27:55.000-0400

  Yes, this fix looks correct to me. The original code just before 0.6 used to do a deep merge here, which is correct.

• Justin Obara commented 2009-07-31T10:39:57.000-0400

  Verified fix using:

  IE 7, FF3 (Win Vista)
  Safari 3, Safari 4, Opera 9.6, FF3.5