FLUID-2784: Uploader unit tests failing

Description

Uploader unit tests failing

http://build.fluidproject.org/infusion/tests/component-tests/uploader/html/Uploader-test.html

Notice that the first 3 sets of unit tests are failing

Environments

FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
Safari 3.2 (Mac OS 10.4)
FF2, FF3, IE6, IE7, IE8, Opera 9.6 (Win XP)
FF3, IE7, IE8 (Win Vista)
IE6 (Win 2000)

Attachments

• FLUID-2784-patch2.txt
• FLUID-2784-selector-patch.txt

Comments

• Michelle D'Souza commented 2009-05-27T11:31:57.000-0400

  The problem is a bad default selector for the manually degrade container. It is an id instead of something that is more reusable. I think it should actually be 'body' since in most cases there would only be a single manual degrade piece of markup for the uploader on a page.

• Michelle D'Souza commented 2009-05-27T11:33:27.000-0400

  Here's a patch that fixes the issue by changing the default selector for the manual degrade container to 'body'.

• Michelle D'Souza commented 2009-05-27T12:00:00.000-0400

  New patch that removed the override of the default selector for the manual degrade container.

• Eli Cochran commented 2009-05-27T12:16:49.000-0400

  I have reviewed the patch and found it worthy

• Eli Cochran commented 2009-05-27T12:20:56.000-0400

  Committed Michelle's patch. The unit test passes again.

• Justin Obara commented 2009-05-27T13:00:16.000-0400

  Verified fix using:

  FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
  FF2, FF3, IE6, IE7, IE8, Opera 9.6 (Win XP)
  FF3, IE7, IE8 (Win Vista)