FLUID-2743: Gracefull Degradation toggle should be first in the tab order

Metadata

Source
FLUID-2743
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Justin Obara
Created
2009-05-19T10:47:40.000-0400
Updated
2009-06-02T10:46:54.000-0400
Versions
N/A
Fixed Versions
  1. 1.1
Component
  1. Uploader

Description

Gracefull Degradation toggle should be first in the tab order

Currently it is placed below the uploader. However, FLUID-2052 will mean that a user may not actually be able to reach the toggle.

The toggle can either be moved ahead of the uploader, or given a tabindex of 1, so that it is reachable first.

Comments

  • Justin Obara commented 2009-05-19T14:20:57.000-0400

    Bug Parade 1.1 release

  • Colin Clark commented 2009-05-22T17:49:21.000-0400

    Here's a patch with a substantial refactoring of the component (formerly called clickToEdit, but renamed to manuallyDegrade to be more inclusive). This refactoring allows the markup to be much more substantially configurable, allowing users to supply their own enable/disable links in the DOM. We still self-render if these aren't present, but also offer a configuration option for the location of the element in the DOM.

  • Colin Clark commented 2009-05-22T18:35:40.000-0400

    Here's a new patch that configures this properly as a decorator, allowing users to control the various configuration options associated with the manuallyDegrade component.

  • Colin Clark commented 2009-05-25T15:11:50.000-0400

    Here's a third patch, making the component more generic and generally tidy.

  • Michelle D'Souza commented 2009-05-26T16:56:35.000-0400

    This is a patch that should apply cleanly to trunk at revision 7252. The actual modifications should be identical to patch c.

  • Justin Obara commented 2009-06-02T10:46:54.000-0400

    Appears to have been resolved with one of the many changes to the uploader during bug parade