FLUID-2720: Only one file is visible in the file queue

Metadata

Source
FLUID-2720
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Eli Cochran
Reporter
Justin Obara
Created
2009-05-13T16:04:57.000-0400
Updated
2011-02-28T16:45:18.283-0500
Versions
  1. 1.0
Fixed Versions
  1. 1.1
Component
  1. Uploader

Description

Only one file is visible in the file queue.

Steps to reproduce:

1) Open the either the server or the demo version of uploader
http://build.fluidproject.org:8080/sakai-imagegallery2-web/site/AddImages/
http://build.fluidproject.org/infusion/components/uploader/html/Uploader.html

2) Add multiple files to the file queue.

Notice that only one of the files is visible in the file queue. If you upload the files, all of them upload.

Environments

IE 8 (Win XP)

Comments

  • Justin Obara commented 2009-05-14T10:11:27.000-0400

    Bug Parade 1.1 release

  • Eli Cochran commented 2009-05-21T11:50:31.000-0400

    so the first row that gets added to the queue is added normally and all subsiquent rows are added with display: none. very odd.

  • Eli Cochran commented 2009-05-21T12:32:20.000-0400

    known jQuery bug: http://dev.jquery.com/ticket/4440
    in IE8 only the first row will be shown if the row is hidden before showing

    row problem... three choices to fix:
    1. special case IE8 and either not hide before show (which is just for animation)
    2. not animate for all browsers
    3. change table to divs, or maybe a fancy list (tempting would be more like the error list then)

    there is one more thing to change and that is to try...

  • Eli Cochran commented 2009-05-21T13:24:04.000-0400

    4th option... which I have tested and works...

    not doing a $().hide() on the row, instead start the row with display: none;

  • Eli Cochran commented 2009-05-21T13:29:09.000-0400

    spoke to soon... doesn't work... we're back to the 3 options

  • Eli Cochran commented 2009-05-21T17:03:28.000-0400

    We've gone with option 1, which means that any code or styles which hide the row must be removed, including the template styling, before the row created.

    The two changes are in Uploader.js:

    In addFile (line 360):
    /* FLUID-2720 - do not hide the row under IE8 */
    if (!($.browser.msie && ($.browser.version >= 8))) {
    row.hide();
    }

    In prepareTemplateElements (line 457):
    /* FLUID-2720 - do hide the row under IE8 */
    if ($.browser.msie && ($.browser.version >= 8)) {
    that.rowTemplate.removeClass(that.options.styles.hiddenTemplate).removeClass(that.options.styles.rowTemplate);
    }

  • Michelle D'Souza commented 2011-02-28T16:45:18.282-0500

    Closing issues that were fixed in 1.1