FLUID-2637: Column Headers still sort, when not set to sortable

Description

Column Headers still sort, when not set to sortable

Reported by Athena 7 in the irc channel at 10:03 am (30 April 09)
http://wiki.fluidproject.org/display/fluid/fluid-work+IRC+Logs-2009-04-30

Attachments

• FLUID-2637_patch_v2.txt
• FLUID-2637_patch_v3.txt
• FLUID-2637_patch_v4.txt
• FLUID-2637_patch_v5.txt
• FLUID-2637_patch.txt

Comments

• y z commented 2009-05-13T10:55:05.000-0400

  Patch for the issue

• y z commented 2009-05-13T11:22:59.000-0400

  Updated patch for the issue

• Justin Obara commented 2009-05-14T09:13:12.000-0400

  Bug Parade 1.1 release

• Antranig Basman commented 2009-05-15T14:04:15.000-0400

  Thanks for this patch, Yura - it works well for the basic functionality, but could perform better. It would be quicker to simply return null from the sorter where not required - although the remainder of this codepath may require fixing. Also, the CSS effect of producing a sort header needs to be prevented.

• y z commented 2009-05-25T12:08:22.000-0400

  Latest version of the patch:

  • some refactoring (not don't call that.options.sorter at all if the column is set to not sortable)
  • if column not sortable we now hide the arrows that indicate sorting order.

• y z commented 2009-05-25T12:44:10.000-0400

  more refactoring:

  • now only pass columnDefs to isSortable instead of OverallThat

• y z commented 2009-05-25T13:03:00.000-0400

  fixed a bug, isSortable now guarded against no sort Key

• Antranig Basman commented 2009-05-25T13:15:58.000-0400

  Thanks for this patch - committed at revision 7228

• Justin Obara commented 2009-05-26T09:07:38.000-0400

  Sorting still partially works when sortable set to false.

  Clicking on a non-sortable header will return the pager to the first page, as well as change the sort order to the default sort order or the page.

• y z commented 2009-05-26T13:19:21.000-0400

  -updated the pager not to resort to default whenever the notSortable header is clicked
  -left the isSortable function, since it's nicely used in other functions other than just generateColumnClick and works as a safeguard

• Antranig Basman commented 2009-05-26T15:21:56.000-0400

  Commited patch v5 - more work required since the CSS affordance of cursor, underlining and "click to sort" is still present on an unsortable column

• Antranig Basman commented 2009-05-26T20:00:24.000-0400

  Final fix at revision 7256 - Pager now supports general affordance of top level "decorators" configuration which may arbitrarily affix to column headers. This functionality may be the Gateway to the South.

• Justin Obara commented 2009-11-13T09:01:47.000-0500

  Closed as per previous comment