FLUID-257: Test Javascript enter-key activation on all browsers

Description

The Lightbox code that responds to the Enter key needs to be tested on all browsers.

We also need todecide whether or not we want to map the Space bar to the same activation.

The code needs to be cleaned up and refactored (e.g. eliminate dependence on lightbox.domNode).

Attachments

• FLUID-257.patch

Comments

• Jonathan Hung commented 2008-03-04T14:50:17.000-0500

  Took a quick spin in true IE 6, IE7, FF3b3, and FF2 on WinXP.

  IE6 - Enter key causes a "default beep" and brings you to the image.
  IE7 - Enter key causes a "default beep" and brings you to the image.
  FF2 - Enter key activates the image without any unexpected behaviour.
  FF3b3 - Enter key activates the image without any unexpected behaviour.

  The default beep is a bit odd. Not sure if we can do anything to fix that in IE6 / 7.

• Jonathan Hung commented 2008-03-04T16:06:18.000-0500

  Space bar does not appear to conflict with any JAWS specific commands. Hitting space bar in either Virtual Cursor on/off will just say "Space".

  Normal browser behaviour for space bar is to scroll the window down.

  Window Eyes would say "Invalid key press" when space bar is pressed.

• Jonathan Hung commented 2008-03-05T13:43:05.000-0500

  On FF2 and FF3 on OS X, the Enter key activates the link as expected. Space bar does not appear to do anything unlike on Windows.

• Jonathan Hung commented 2008-03-05T15:09:02.000-0500

  Too hasty in closing bug. Re-opened due to my confusion about removing the dependency on lightbox.domNode.

• Colin Clark commented 2008-03-05T15:57:34.000-0500

  Here's an option that gets rid of dependence on the activeItem completely, since we can guarantee that evt.target is the activeItem. I also changed the code to take the Lighbox's container element rather than the lightbox itself. This is your #2 option, Jonathan.

  This is just a start. The code could be further cleaned up. One of my concerns is the way we search for any anchors within the event's target and just activate the first. Works reasonably for the Lightbox, but we could also choose to key of a known ID on one of the hyperlinks.

  I've only tested this in FF3. Please test it more widely and let me know what you think.

• Jonathan Hung commented 2008-03-06T11:08:39.000-0500

  I wasn't sure how we can guarantee that the evt.target is the activeItem, so I did some looking.

  According to Quirksmode: http://www.quirksmode.org/js/events_properties.html#target

  "Even if an event is captured or bubbles up, the target/srcElement always remains the element the event took place on."

  Good to know.

• Colin Clark commented 2008-03-11T15:57:37.000-0400

  Fixed in r4723 by removing the dependency on lightbox.domNode and using the event's target instead.