FLUID-2380: jQuery UI dialog, should be styled using FSS

Metadata

Source
FLUID-2380
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Jacob Farber
Reporter
Justin Obara
Created
2009-03-18T14:22:59.000-0400
Updated
2011-02-28T16:45:19.139-0500
Versions
  1. 1.0
Fixed Versions
  1. 1.1
Component
  1. UI Options

Description

jQuery UI dialog, should be styled using FSS

Currently the jQuery UI Dialog is using it's own styles, instead of the FSS styles set in UI Options.

Steps to reproduce:

1) Open the sakai mock-up example from the daily build site
http://build.fluidproject.org/fluid/sample-code/shared/sakai/sakai.html

2) Open the UI Options dialog

3) Change some of the options, and save the changes.

Notice that the dialog doesn't change

Environments

FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
Safari 3.2 (Mac OS 10.4)
FF2, FF3, IE6, IE7, Opera 9.6 (Win XP)
FF3, IE7 (Win Vista)
IE6 (Win 2000)

Comments

  • Justin Obara commented 2009-03-18T15:54:56.000-0400

    Bug Parade release comment removed

  • Anastasia Cheetham commented 2009-03-23T15:37:50.000-0400

    I've reviewed the changes for this fix. They look good, but there are some commented lines in the sakai.html header and in the sakai.js dialog_container.dialog() initialization that should be removed.

  • Justin Obara commented 2009-03-23T15:39:37.000-0400

    need to removed commented out code

  • Anastasia Cheetham commented 2009-03-23T16:39:45.000-0400

    Looks good +1

  • Justin Obara commented 2009-03-23T17:22:22.000-0400

    Verified fix using:

    FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
    FF2, FF3, IE6, Opera 9.6 (Win XP)
    FF3, IE7 (Win Vista)

  • Justin Obara commented 2009-03-24T10:27:33.000-0400

    use custom jQuery UI Themes for jQuery UI widgets

  • Michelle D'Souza commented 2009-03-26T11:30:01.000-0400

    There have been improvements made for 1.0 but there are still more improvements to be made.

  • Justin Obara commented 2009-05-14T09:06:41.000-0400

    Bug Parade 1.1 release

  • Laurel Williams commented 2009-05-25T14:56:41.000-0400

    Had a look at the code changes, which are quite extensive and touch many files. *note some of the file names seem to have changed since these file names were generated by commit emails. Did not see anything which caused offense. Visually checked these out in Opera, IE8, FF3 on win xp.

    M /fluid/components/trunk/src/webapp/fluid-components/css/fluid.layout.css
    M /fluid/components/trunk/src/webapp/fluid-components/css/fluid.theme.coal.css
    M /fluid/components/trunk/src/webapp/fluid-components/css/fluid.theme.mist.css
    M /fluid/components/trunk/src/webapp/fluid-components/css/fluid.theme.slate.css
    M /fluid/components/trunk/src/webapp/sample-code/shared/sakai/css/sakai.css
    M /fluid/components/trunk/src/webapp/sample-code/shared/sakai/js/sakai.js
    M /fluid/components/trunk/src/webapp/sample-code/shared/sakai/sakai.html
    M /fluid/infusion/trunk/src/webapp/integration-demos/sakai/html/ui-options-fss-sakai.html
    M /fluid/infusion/trunk/src/webapp/components/uiOptions/css/UIOptions.css
    M /fluid/infusion/trunk/src/webapp/components/uiOptions/html/UIOptions.html
    M /fluid/infusion/trunk/src/webapp/lib/jquery/ui/css/fl-theme-coal/jquery-ui-1.7.1.custom.css
    M /fluid/infusion/trunk/src/webapp/lib/jquery/ui/css/fl-theme-hc/jquery-ui-1.7.1.custom.css
    M /fluid/infusion/trunk/src/webapp/lib/jquery/ui/css/fl-theme-hci/jquery-ui-1.7.1.custom.css
    M /fluid/infusion/trunk/src/webapp/lib/jquery/ui/css/fl-theme-mist/jquery-ui-1.7.1.custom.css
    M /fluid/infusion/trunk/src/webapp/lib/jquery/ui/css/fl-theme-slate/jquery-ui-1.7.1.custom.css
    + numerous images

  • Justin Obara commented 2009-05-25T15:50:05.000-0400

    Needs to update file names for css files and fix broken images

  • Jacob Farber commented 2009-05-25T16:09:51.000-0400

    Inverted high contrast theme has broken images, so i will re-download the theme

  • Michelle D'Souza commented 2011-02-28T16:45:19.137-0500

    Closing issues that were fixed in 1.1