FLUID-2355: [Uploader] implement Upload with Error storycard

Description

Implement the designs as described in the Upload with Error storyboard

http://wiki.fluidproject.org/display/fluid/Uploader+Storyboard+-+Upload+with+Error

Attachments

• FLUID-2355.a.patch
• FLUID-2355.b.patch

Comments

• Colin Clark commented 2009-03-18T18:14:37.000-0400

  I've attached a patch that provides some refactoring for the error handling code. All changes are in the FileQueueView portion of Uploader.js, along with some changes to the HTML template. Here's a summary of what's in this patch:

  1. We broke out a separate errorRowForFile() method so the means of databinding is more clear. This is also symmetrical with other similar methods in the code.

  2. The error row rendering code in showErrorForFile() was split out into a separate method, renderErrorInfoRowFromTemplate().

  3. The error row template was moved from the bottom of the file directly into the file queue to simplify the DOM structure.

  4. Our templating strategy in the FileQueueView was changed so that we grab all necessary templates out of the DOM immediately upon instantiation, and then remove them from the DOM so they don't get in the way.

  5. Error messages strings were moved into the options.strings bundle.

  6. Various small refactoring, renaming, and linting.

  I've introduced one bug that needs to be fixed before this code is acceptable. Now, when you add a single file to the queue, there's a row-sized gap above the file row in the queue. Add two or more files, and it doesn't appear. Probably a minor styling issue, but awkward nonetheless.

• Eli Cochran commented 2009-03-19T01:18:40.000-0400

  The patch looks great, works great!

  I'm still wrapping my head around the formatting bug... something seriously screwed up here. The obvious problem is that the row is getting set with a style of display:block. Definitely wrong but something else is going on too.

  Need to update AddImages.html in Image Gallery to match the new names in Progressive Enhancement. Because it's broken now. I have that fix to check in when this patch lands.

• Colin Clark commented 2009-03-19T15:54:33.000-0400

  Here's a patch that fixes the gap issue in the queue.

• Eli Cochran commented 2009-03-19T17:18:45.000-0400

  Reviewed Colin's B patch. Looks great to me.

  Definitely fixes the display problem.

  I will commit!

• Justin Obara commented 2009-03-20T09:01:30.000-0400

  This commit seems to have broken a bunch of unit tests in FileQueueView-test.html

• Eli Cochran commented 2009-03-20T20:22:15.000-0400

  The patch for FLUID-2351 adds some additional styling for this StoryCard, specifically the styling the footer of the Uploader to indicate whether there were errors or everything was OK.

  The tests are still broken!

• Eli Cochran commented 2009-03-24T18:45:29.000-0400

  I have bad news about the Uploader Storyboard - Upload with Error.

  My attempts to get the Uploader to retry errored files has failed.

  After trying a number of things and reviewing both the docs and the forums, it seems that the SWFUpload component that we're using, simply doesn't support this feature as we expected it to work.

  So, we did manage to get improved error messages in, but no Retry in any manner.