FLUID-2334: [Uploader] file progressors display in the wrong positions, if files are added to a completed upload

Metadata

Source
FLUID-2334
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Eli Cochran
Reporter
Eli Cochran
Created
2009-03-11T19:47:29.000-0400
Updated
2009-03-26T10:32:54.000-0400
Versions
  1. 0.8
Fixed Versions
  1. 1.0
Component
  1. Uploader

Description

OK, this is a little more serious than the summary would indicate.

The problem is that if you let the upload run to the end, and then add more files to the queue, file id's get reused.

We use the file id to position the progressor for the file row. So the progressor displays in the wrong position.

Comments

  • Eli Cochran commented 2009-03-11T19:56:03.000-0400

    Apparently the reuse of id's is a well-known bug in SWFUpload 2.2.0 which "We have yet to find a satisfactory work-around." - Gyphie

    And in case it isn't clear in the above description, we end up with duplicate ids for rows in the DOM which is definitely a no-no.

  • Eli Cochran commented 2009-03-11T20:38:34.000-0400

    OK, I'm feeling better about this one. I can only reproduce it in the demo version of the Uploader. On the server, everything seems fine. Need to do more testing.

  • Justin Obara commented 2009-03-12T11:26:19.000-0400

    Bug Parade 1.0 release

  • Eli Cochran commented 2009-03-20T20:19:17.000-0400

    Fixed with the patch added to FLUID-2351

    Since we're no longer messing with the DOM ancestor of Flash object we don't get new ids so the progressors show up in the right places.

  • Jacob Farber commented 2009-03-26T10:15:59.000-0400

    Reviewed, and it works for me.

  • Justin Obara commented 2009-03-26T10:32:54.000-0400

    Verified fix using:

    FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
    FF2, FF3, IE6, Opera 9.6 (Win XP)
    FF3, IE7 (Win Vista)