FLUID-2243: Can't use the keyboard to activate a link in an inline edit field

Metadata

Source
FLUID-2243
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Justin Obara
Created
2009-02-16T22:55:59.000-0500
Updated
2009-02-18T08:44:50.000-0500
Versions
  1. 0.7
  2. 0.8
Fixed Versions
  1. 0.8
Component
  1. Inline Edit

Description

Can't use the keyboard to activate a link in an inline edit field

Steps to reproduce.

1) Open the rich text inline edit example
http://build.fluidproject.org/fluid/tests/fluid-tests/manual/inline-edit/rich-text-inline-edit.html

2) Open one of the FCK rich text inline edit fields and add a link

3) Tab to the link and press the 'enter' key

Notice that the inline edit field opens in edit mode instead of activating the link

Comments

  • Antranig Basman commented 2009-02-17T11:00:06.000-0500

    Fixed at revision 6518, assigned for review

  • Antranig Basman commented 2009-02-17T12:23:03.000-0500

    Summary of recent chat:

    (17:09:59) Bosmo1: We have agreed to change the "return value semantics" of activatable to "browser defaults", since we aren't aware of any code that ever depended on this -
    (17:10:26) Bosmo1: There was never any specification on the meaning of the return value of an activatable handler, but the majority of users would probably have expected it to agree with a normal event handler in any case
    (17:10:59) Bosmo1: To make this consistent, it would be even better if we changed the argument semantics to agree to the JQuery standard too, but that is too much of a change for this release, especially at this point
    (17:11:16) Bosmo1: So we will push out that argument normalisation to 1.0, as well as a general rethinking of activatable which has a number of issues with its API

  • Colin Clark commented 2009-02-17T18:01:32.000-0500

    I've reviewed Antranig's second fix to this issue and it looks good. +1

  • Justin Obara commented 2009-02-18T08:44:49.000-0500

    Verified fix using:

    FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
    FF3, IE7 (Win Vista)