FLUID-2224: [Uploader] DemoUploadManager-test broken by b5 checkin (6480)

Metadata

Source
FLUID-2224
Type
Sub-issue
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Eli Cochran
Created
2009-02-11T19:47:02.000-0500
Updated
2009-02-17T10:02:11.000-0500
Versions
  1. 0.7
Fixed Versions
  1. 0.8
Component
  1. Uploader

Description

When upgrading the code base to use SWFUpload b5, we broke the unit test for the DemoUploadManager. All tests fail.

Comments

  • Justin Obara commented 2009-02-12T10:05:45.000-0500

    Bug Parade 0.8 release

  • Justin Obara commented 2009-02-12T10:06:50.000-0500

    swfuploader unit tests are also failing

  • Colin Clark commented 2009-02-12T17:38:44.000-0500

    The DemoUploadManager tests are failing due to SWFUpload b5's insistence on having a DOM element to squash, even in Flash 9.

    The SWFUploadManager tests were failing because of "features" that we were able to remove from the code now that SWFUpload b5 fixed a few issues.

  • Colin Clark commented 2009-02-16T23:07:09.000-0500

    Fixed as of revision 6494.

  • Justin Obara commented 2009-02-17T08:58:18.000-0500

    Tested this fix using:

    FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
    FF3, IE7 (Win Vista)

    Will close after code review

  • Eli Cochran commented 2009-02-17T09:40:15.000-0500

    I have reviewed Colin's fix and it looks great. Perhaps the most tongue-in-cheek code that we have in our code-base, but completely correct.