Metadata
- Source
- FLUID-2195
- Type
- Bug
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Antranig Basman
- Reporter
- Anastasia Cheetham
- Created
2009-02-04T10:37:49.000-0500 - Updated
2009-06-03T13:46:28.000-0400 - Versions
-
- 0.7
- Fixed Versions
-
- 0.8
- Component
-
- Renderer
Description
The first line of resolveMessageSource() in fluidRenderer.js reads:
if (messageSource.type = "data") {
I suspect that "=" should be "===" instead.
Comments
-
Anastasia Cheetham commented
2009-02-04T12:04:45.000-0500 The renderer unit tests do have tests for UIMessage rendering. Tests should be added that catch this bug as part of the process of fixing it.
-
Antranig Basman commented
2009-02-04T12:38:13.000-0500 Fixed at revision 6419 - In fact we do not support any other kinds of MessageSource than "data" right now, so it could be argued that the current implementation is just being "generous" 😛
To be honest, I don't directly recall what other kinds of MessageSource were planned right now, but hopefully this will become obvious again once/if we start working more heavily with I18Ned templates. It will become possible to write a test for this issue once we do support a second type of MessageSource 😛