FLUID-2121: Focus is not placed on the first focusable item in the user interface options dialog

Metadata

Source
FLUID-2121
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Jacob Farber
Reporter
Justin Obara
Created
2009-01-13T13:50:22.000-0500
Updated
2009-03-20T11:24:56.000-0400
Versions
  1. 0.6
  2. 0.7
  3. 0.8
Fixed Versions
  1. 1.0
Component
  1. UI Options

Description

Focus is not placed on the first focusable item in the user interface options dialog

Steps to reproduce:

1) Open the sakai mock-up example from the daily build site:
http://build.fluidproject.org/fluid/sample-code/shared/sakai/sakai.html#

2) Click "Edit Appearance" to open the user interface options dialog

3) Tap the tab key

Notice that focus was not on the first focusable item in the dialog, it appears as though focus isn't even in the dialog at all

Environments

FF2, FF3, Safari 3 (Mac OS 10.5)
FF2, FF3, IE6, IE7 (Win XP)
FF3, IE7 (Win Vista)
FF3, IE6 (Win 2000)

Comments

  • Justin Obara commented 2009-02-06T12:03:15.000-0500

    Bug Parade 0.8 release

  • Jacob Farber commented 2009-02-11T15:53:13.000-0500

    jQuery UI dialog now forces proper focus

  • Justin Obara commented 2009-02-11T15:54:34.000-0500

    Speaking to Joseph about this.

    He suggested that the "Close" button be part of a title bar and activated by using the "esc" key or clicking on it with the mouse.

    The first focusable element in the dialog should be the first item or whatever makes the most sense.

    In our case this would likely be the accordion (when it is implemented) or the first option.

  • Justin Obara commented 2009-02-12T10:23:50.000-0500

    It seems as though the commit at r6487 has caused IE to take approximately 10 minutes to load the UI Options Dialog.

  • Jacob Farber commented 2009-02-12T10:47:19.000-0500

    I went to the link http://build.fluidproject.org/fluid/sample-code/shared/sakai/sakai.html , hit the button and it loaded within a second or two....
    Also, the ESC key closes the dialog, as far as I can tell.

  • Justin Obara commented 2009-03-12T11:31:35.000-0400

    Bug Parade 1.0 release

  • Michelle D'Souza commented 2009-03-20T10:43:16.000-0400

    I tested this and reviewed the code. It works nicely.

  • Justin Obara commented 2009-03-20T11:24:56.000-0400

    Verified fix using:

    FF2, FF3 (Mac OS 10.5)
    FF2, FF3, IE6, (Win XP)
    FF3, IE7 (Win Vista)