Metadata
- Source
- FLUID-2059
- Type
- Bug
- Priority
- Critical
- Status
- Closed
- Resolution
- Won't Fix
- Assignee
- N/A
- Reporter
- Antranig Basman
- Created
2009-01-06T14:06:53.000-0500 - Updated
2009-01-12T10:58:21.000-0500 - Versions
-
- 0.6
- Fixed Versions
-
- 0.7
- Component
-
- Framework
Description
The "reverse" option to the fluid options merging algorithm does not correctly preserve the structure in the target of the merge. This merging policy is used when options supplied by subcomponents are submitted for merging against the top-level options structure. This leads to inconvenience, as well as some fragility, when these subcomponent options need to be customised by users. For example, in the uploader, in file
https://source.fluidproject.org/svn/fluid/image-gallery/trunk/web/src/main/webapp/AddImages.html
the following section appears:
decorators: {
type: "fluid.swfUploadSetupDecorator",
options: {
flash9URL: "../../fluid-components/flash/swfupload_f9.swf",
flash10URL: "../../fluid-components/flash/swfupload_f10.swf",
flashButtonImageURL: "../../fluid-components/images/uploader/browse.png"
}
}
the specification of "type" should be inherited from the default options and not require respecification unless it requires to be modified.
Comments
-
Justin Obara commented
2009-01-06T14:21:35.000-0500 Bug Parade 0.7 release
-
Colin Clark commented
2009-01-07T16:13:38.000-0500 It looks to me like this isn't really a bug. See the initSubcomponents unit test in FluidJSTests. Can someone review this for me?
-
Justin Obara commented
2009-01-12T10:58:21.000-0500 This is not a bug, but rather an input error that had not yet been documented. It has now been added to the documentation: http://wiki.fluidproject.org/display/fluid/Subcomponents.