FLUID-1982: Uploader: after Upload stop, all delete buttons no longer function

Description

After beginning an upload and then canceling half way through the remove file buttons are all disabled.

Attachments

• FLUID-1982.a.patch
• FLUID-1982-swfupload.patch
• FLUID-1982-uploader.patch

Comments

• Eli Cochran commented 2008-12-15T19:38:38.000-0500

  onUploadComplete we need to restore the buttons to their former state.

• Colin Clark commented 2008-12-15T20:22:04.000-0500

  For Infusion 0.6, we'll work around this issue by ensuring all the remove buttons are greyed out, to give the use a cue that they aren't working. In the end, this is probably okay because there is another bug that causes uploads to stall after stopping them and removing files. 😉

• Justin Obara commented 2009-01-06T12:13:28.000-0500

  Bug Parade 0.7 release

• Colin Clark commented 2009-01-06T15:26:33.000-0500

  It's possible that we could fix the underlying issue where an exception is thrown in SWFUpload's code when files are removed from its queue... don't remove anything from their queue. We'd essentially have to change the upload flow to always specify a specific file ID to upload, rather than just letting it whip through its queue one by one. A possibility to explore.

• Eli Cochran commented 2009-01-09T13:38:43.000-0500

  So it appears that Pausing the queue actually has nothing to do with this bug. In fact, all you have to do is remove files from the queue before you start the Upload.

• Eli Cochran commented 2009-01-11T15:23:28.000-0500

  Bug appears restricted to the Flash 9 version and may be an incompatibility between the 2.2.0 scripts and the old 2.1.0 version of Flash that we're using for Flash 9.

• Eli Cochran commented 2009-01-11T23:20:16.000-0500

  OK, I have the problem but not the fix.

  The actionScript code for CancelUpload in 2.1.0 takes a single parameter, in 2.2.0 it takes two. We're using the swfupload.js for 2.2.0 which passes two and there for it fails when passed to the Flash component. When I modified the swfupload.js file to only pass one param, it worked again.

  It appears that removing the second parameter continues to work with the 2.2.0 Flash file, since it has a default value (the value which we want). So we could modify swfupload.js. I'm not thrilled by the idea of shipping a modified version of this file but seems like the only solution.

• Colin Clark commented 2009-01-12T23:47:51.000-0500

  Here's a patch for swfupload.js based on what's currently in the FLUID-1982 branch (r6298). I created to make it easy to apply this fix against the trunk in case Justin wants to merge this feature without having to deal with the mechanics of branch merges.

• Colin Clark commented 2009-01-12T23:48:44.000-0500

  Here's a patch for Uploader.js based on what's currently in the FLUID-1982 branch (r6298). I created it to make it easy to apply this fix against the trunk in case Justin wants to merge this feature without having to deal with the mechanics of branch merges.

• Jacob Farber commented 2009-01-13T09:53:41.000-0500

  Double checked and tested the patches, and all is good. Justin is adding a comment on a simulateUplod() error.

• Justin Obara commented 2009-01-13T09:57:16.000-0500

  I ran some tests, with Jacob's help (see above comment). It seems to fix this issue and FLUID-2020, but does not resolve FLUID-2010

• Justin Obara commented 2009-01-13T10:32:36.000-0500

  Applied the FLUID-1982-swfupload.patch and FLUID-1982-uploader.patch files.

• Justin Obara commented 2009-01-13T10:33:20.000-0500

  Verified fix using:

  FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
  FF2, FF3, IE6, IE7, Opera 9.5 (Win XP)
  FF3, IE7 (Win Vista)