FLUID-1966: CSS positioning styles for the inline edit dropdown component are not correct

Metadata

Source
FLUID-1966
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Jacob Farber
Reporter
Antranig Basman
Created
2008-12-12T10:34:52.000-0500
Updated
2009-01-13T13:41:53.000-0500
Versions
  1. 0.6beta1
  2. 0.6
Fixed Versions
  1. 0.7
Component
  1. Inline Edit

Description

The inline edit dropdown sample at http://build.fluidproject.org/fluid/tests/fluid-tests/manual/inline-edit/dropdown.html shows a CSS issue to do with the positioning of the popup for the selection control relative to the initiating control. This should really be positioned so that the top member of the list is directly below the "select box" which is displayed - however, on most browsers the dropdown list tends to overlap the selection box about halfway.

Environments

FF2, Opera: WinXP (possibly others)

Attachments

Comments

  • Justin Obara commented 2008-12-12T10:54:49.000-0500

    Bug Parade 0.6 release

  • Jacob Farber commented 2008-12-13T23:43:13.000-0500

    This patch employs some CSS and markup changes, HOWEVER this solution requires more: in order to complete the effect of a fake inline combo box, something needs to push the content "around" the combo box to avoid having it block content following it.
    I suggest either not hiding the "viewEl" and adding to it the following css padding-right: {whatever the width diff between the viewEl and the combobox is} or using an inline element placeholder with the width of the combobox; either way, an inline element is needed to "push" the content around to complete the effect

  • Anastasia Cheetham commented 2008-12-15T10:45:21.000-0500

    Before applying this patch, I was able to reproduce the bug in FF2 and Opera on Win XP. After applying the patch, the problem is still present - it looks unchanged.

  • Jacob Farber commented 2008-12-15T12:59:48.000-0500

    Sorry, original was the wrong patch

  • Anastasia Cheetham commented 2008-12-15T13:43:08.000-0500

    This new patch does fix the issue in FF2 on WinXP, but in Opera (in both WinXP and Mac OS X), the drop-down list jumps to the very top left of the entire window.

    Also, I'm concerned that the patch is affecting the css file that comes with the jquery selectbox plugin, which is not our code. I don't know whether or not its something we might update at some point.

  • Antranig Basman commented 2008-12-15T13:56:25.000-0500

    Hi Anastasia - it is fine to affect the plugin code, since this is where the bug lies - you can see the problem in their standalone demo. It is not a very "core" plugin. I also see the Opera jumping effect. However, we should make sure not to patch their CSS in a way which depends in any way on our own classes or infrastructure.

  • Justin Obara commented 2009-01-12T13:36:45.000-0500

    Bug Parade 0.7 release

  • Jacob Farber commented 2009-01-12T16:18:55.000-0500

    Deleted previous patches, attached patch which solves problem in all browsers but Opera 9.x
    This is believed to be a nested positioning bug, as Justin confirmed this patch works in Opera 8.5

  • Michelle D'Souza commented 2009-01-13T11:00:47.000-0500

    I reviewed the patch and it looks great.

  • Justin Obara commented 2009-01-13T11:22:56.000-0500

    Verified fix using:

    FF2, FF3, Safari 3 (Mac OS 10.5)
    FF3, IE7 (Win Vista)

    NOTE that Opera 9.5 suffers from FLUID-2116