FLUID-1963: UI Options should show current styling options as selected

Metadata

Source
FLUID-1963
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Michelle D'Souza
Reporter
Justin Obara
Created
2008-12-11T15:13:18.000-0500
Updated
2008-12-15T14:12:20.000-0500
Versions
N/A
Fixed Versions
N/A
Component
  1. UI Options

Description

when you open the iFrame the selected settings are always the same, to start, no matter what the current style on the page is

Steps to reproduce:

1) Open the sakai mock-up:
http://build.fluidproject.org/fluid/sample-code/shared/sakai/sakai.html

2) Click on the "Edit Preferences" button

3) Change the colour scheme, click on "save and Apply your Preferences", and click close

4) Click on the "Edit Preferences" button

Notices that the original styling options are selected not the current style's options

Environments

FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
FF2, FF3, IE6, IE7, Opera 9.5 (Win XP)
FF3, IE7 (Win Vista)
FF3, IE6 (Win 2000)

Comments

  • Michelle D'Souza commented 2008-12-15T12:36:08.000-0500

    Patch file that initializes the UI Options component only once.

  • Michelle D'Souza commented 2008-12-15T12:41:40.000-0500

    This regression was reintroduced in revision 6190. The problem is that the UI Options component was being initialized every time the 'Edit Appearance' button was pressed. I've created a patch that initializes the component only on the first time the button is pressed.

  • Michelle D'Souza commented 2008-12-15T12:52:39.000-0500

    Linted patch with license.

  • Anastasia Cheetham commented 2008-12-15T12:58:39.000-0500

    I have reviewed this patch, and it looks good to me.

  • Justin Obara commented 2008-12-15T14:12:20.000-0500

    Verified fix using

    FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
    FF2, FF3, IE7, Opera 9.5 (Win XP)
    FF3, IE7 (Win Vista)