Metadata
- Source
- FLUID-1952
- Type
- Bug
- Priority
- Blocker
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Anastasia Cheetham
- Reporter
- Justin Obara
- Created
2008-12-09T15:03:35.000-0500 - Updated
2011-01-30T11:58:17.762-0500 - Versions
-
- 0.6beta1
- 0.6
- 0.7
- Fixed Versions
-
- 0.8
- Component
-
- Framework
Description
Committed code should not have console.log() functions
at least nested.html has a call to console.log
Comments
-
Justin Obara commented
2009-02-06T12:02:14.000-0500 Bug Parade 0.8 release
-
Anastasia Cheetham commented
2009-02-11T12:37:51.000-0500 I searched the code base for console.log, and didn't find anything else in our code besides nested.html. I updated that file to use fluid.log, and now IE doesn't complain anymore.
-
Antranig Basman commented
2009-02-16T18:38:14.000-0500 I have reviewed this, and found some stray references in "versioning/list.html". These have been updated to fluid.log, but unfortunately the sample doesn't seem to work any more - the 0.8 version of the reorderer no longer works,
apparently because of some form of JQuery UI conflict. Other than this, I confirmed that no unguarded references to "console" occur in our codeset. Some 3rd party code (jquery.selectbox, tinyMCE, testrunner, etc.) do make use of console.log, as do we as an option in Fluid.js, but these either perform a guard to check for existence, or (more disagreeably in the case of 3rd party code) assign a dummy value to it. We can sign this one off -
Colin Clark commented
2009-02-16T21:28:33.000-0500 I've reviewed both Anastasia's (r6481) and Antranig's (r6511) commits, and they're just fine. +1 on these for inclusion in Infusion 0.8.
-
Justin Obara commented
2009-02-16T22:24:36.000-0500 Verified fix on the two pages mentioned in the above comments, using:
IE 6 (Win XP)
-
Michelle D'Souza commented
2011-01-30T11:56:39.366-0500 Reopening these issues to add the frameworkcomponent