FLUID-1942: Prepare progressive enhancement-related code for release

Metadata

Source
FLUID-1942
Type
Sub-issue
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Colin Clark
Created
2008-12-08T11:58:58.000-0500
Updated
2008-12-10T09:12:43.000-0500
Versions
N/A
Fixed Versions
  1. 0.6
Component
  1. Uploader

Description

A couple of little tasks to ensure that the recent progressive enhancement-related code is ready for release:

  • link against an unminified version of swfobject.js
    *remove the unused swfupload-swfobject.js file
  • ensure that the licenses are correctly articulated
  • update the build scripts to include swfobject.js and ProgressiveEnhancement.js

Attachments

Comments

  • Justin Obara commented 2008-12-08T12:06:14.000-0500

    Bug Parade 0.6 release

  • Colin Clark commented 2008-12-08T17:24:44.000-0500

    Here's a patch that does the following:

    1. Removes the minified version of swfobject.js in favour of the unminified version
    2. Updates the build scripts to copy the correct licenses and include ProgressiveEnhancement.js along with swfobject.js
    3. Fixes a minor bug in the order of library inclusion in Fluid-all.js
    4. Removes swfupload.swfobject.js, which is not used in Uploader 2
    5. License renaming for swfuploader and swfobject

    Apologies for the size of this patch, but you'll notice that the vast majority of it is the addition and removal of the swfobject files.

  • Justin Obara commented 2008-12-10T09:10:21.000-0500

    Quote from Antranig's code reivew comment on the fluid-work list

    "Hi there - I have looked at this patch, and it appears benign to me.

    Cheers,
    A."

  • Justin Obara commented 2008-12-10T09:11:09.000-0500

    Verified fix.

    Tested no js condition using
    FF2 and FF3 (Win XP)

  • Justin Obara commented 2008-12-10T09:11:28.000-0500

    re-openned issue to edit a comment