FLUID-1825: Undo should not require model to be inside 'value'

Metadata

Source
FLUID-1825
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Anastasia Cheetham
Reporter
Anastasia Cheetham
Created
2008-11-18T16:21:47.000-0500
Updated
2009-03-17T17:22:20.000-0400
Versions
  1. 0.6beta1
  2. 0.6
  3. 0.7
  4. 0.8
Fixed Versions
  1. 1.0
Component
  1. Framework

Description

The current implementation of Undo requires that a component model be inside an object called 'value' inside the model, i.e. "that.model.value" (see the click handlers bound to "undoControl" and "redoControl" in Undo.js, inside bindHandlers()).

This indirection should not be required - anything living at .model should be treated as the model.

Comments

  • Justin Obara commented 2009-03-12T11:25:39.000-0400

    Bug Parade 1.0 release

  • Antranig Basman commented 2009-03-17T15:24:04.000-0400

    Fixed at revision 6764 - note new API, updateModelValue for InlineEdit

  • Anastasia Cheetham commented 2009-03-17T17:06:38.000-0400

    I've reviewed and tested the changes for this, and they look good to me. Undo no longer has this requirement. I'll update the Undo documentation accordingly.

  • Justin Obara commented 2009-03-17T17:22:20.000-0400

    closed based on the above review and testing