FLUID-1803: editable items lose all their classes on init

Metadata

Source
FLUID-1803
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Eli Cochran
Created
2008-11-13T14:26:23.000-0500
Updated
2008-11-17T08:51:08.000-0500
Versions
  1. 0.6beta1
Fixed Versions
  1. 0.6
Component
  1. Inline Edit

Description

when presented with markup such as:

<div class="inlineEditable">
<span class="text sectionName">Astronomy 7A P 001 LEC</span>
</div>

once inlineEdit has initialized the DOM is:

<div class="inlineEditable">
<span class="">Astronomy 7A S 102 LEC</span>
<span><input type="text" class="edit"/></span>
</div>

note the lack of classes in the class attribute

Attachments

Comments

  • Eli Cochran commented 2008-11-13T14:45:46.000-0500

    Added a patch FLUID-1803.patches that changes the default style key from defaultViewText to defaultViewStyle and updates the references to it

  • Antranig Basman commented 2008-11-13T22:10:38.000-0500

    Looks like this was resolved with test case at revision 6022.

  • Justin Obara commented 2008-11-14T09:02:11.000-0500

    The styling information appears to be present, but the class is still removed.

    <span class="" style="padding-right: 3px;" tabindex="0" role="wairole:button">Astronomy 7A P 001 LEC</span>

    Is this the correct behaviour?

  • Eli Cochran commented 2008-11-14T09:40:44.000-0500

    No it isn't. So now I'm confused as my commit doesn't seem to have taken.

  • Eli Cochran commented 2008-11-14T09:48:20.000-0500

    I've looked into it and I'm not seeing the same behavior. Once rendered, I see:
    <span class="text sectionName" style="padding-right: 3px;" tabindex="0" role="button">

  • Justin Obara commented 2008-11-17T08:51:08.000-0500

    I'm now seeing the correct behaviour..

    Verified fix using:

    FF2 (Mac OS 10.5)